gentoo-ebuilds/media-libs/giflib/files/giflib-5.2.2-fortify.patch
Sam James 033629cddf
media-libs/giflib: add 5.2.2
The release notes mention CVE-2023-48161 and CVE-2022-28506 by CVE but
there's a bunch of other security fixes in the list of fixes.

The documentation in this release also adds:
"""
+<refsect1><title>Bugs</title>
+
+<para>Feeding this utility a GIF with an invalid colormap, or other
+kinds of malformations, index will produce invalid output and may
+core-dump the tool. Don't do that.</para>
+
+</refsect1>
"""

Anyway, on the ebuild side:
* Replace Makefile patch for doc building conditionally with a sed
* Make tests more verbose (needed it when debugging bug #848807)
* Cleanup reallocarray hack (bug #677956)
* Add LFS support (bug #915316)

Bug: https://bugs.gentoo.org/677956
Bug: https://bugs.gentoo.org/785664
Bug: https://bugs.gentoo.org/851945
Bug: https://bugs.gentoo.org/918539
Closes: https://bugs.gentoo.org/848807
Closes: https://bugs.gentoo.org/915316
Signed-off-by: Sam James <sam@gentoo.org>
2024-05-30 04:53:53 +01:00

27 lines
868 B
Diff

https://bugs.gentoo.org/848807
Fix incorrect length args to snprintf.
Upstream bug: https://sourceforge.net/p/giflib/bugs/170/
--- a/giftext.c
+++ b/giftext.c
@@ -442,7 +442,7 @@
for (i = 1; i <= Len; i++) {
(void)snprintf(&HexForm[CrntPlace * 3], 3, " %02x",
Extension[i]);
- (void)snprintf(&AsciiForm[CrntPlace], 3, "%c",
+ (void)snprintf(&AsciiForm[CrntPlace], 2, "%c",
MAKE_PRINTABLE(Extension[i]));
if (++CrntPlace == 16) {
HexForm[CrntPlace * 3] = 0;
@@ -488,7 +488,7 @@
for (i = 0; i < Len; i++) {
(void)snprintf(&HexForm[CrntPlace * 3], 3, " %02x",
PixelBlock[i]);
- (void)snprintf(&AsciiForm[CrntPlace], 3, "%c",
+ (void)snprintf(&AsciiForm[CrntPlace], 2, "%c",
MAKE_PRINTABLE(PixelBlock[i]));
if (++CrntPlace == 16) {
HexForm[CrntPlace * 3] = 0;