Keith Thompson
184f71cc68
patch 9.1.0006: is*() and to*() function may be unsafe
...
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0
(v9.0.2054)
fixes : #13332
closes : #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 21:19:04 +01:00
Bram Moolenaar
50809a45eb
patch 9.0.1572: error messages are not translated
...
Problem: Error messages are not translated.
Solution: Add _().
2023-05-20 16:39:07 +01:00
Yegappan Lakshmanan
960dcbd098
patch 9.0.1391: "clear" macros are not always used
...
Problem: "clear" macros are not always used.
Solution: Use ALLOC_ONE, VIM_CLEAR, CLEAR_POINTER and CLEAR_FIELD in more
places. (Yegappan Lakshmanan, closes #12104 )
2023-03-07 17:45:11 +00:00
Bram Moolenaar
ebfec1c531
patch 9.0.1234: the code style has to be checked manually
...
Problem: The code style has to be checked manually.
Solution: Add basic code style checks in a test. Fix or avoid uncovered
problems.
2023-01-22 21:14:53 +00:00
Yegappan Lakshmanan
7f8b2559a3
patch 9.0.1158: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11787 )
2023-01-08 13:44:24 +00:00
Bram Moolenaar
436b5adc97
patch 8.2.3961: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
2021-12-31 22:49:24 +00:00
Dominique Pelle
af4a61a85d
patch 8.2.3914: various spelling mistakes in comments
...
Problem: Various spelling mistakes in comments.
Solution: Fix the mistakes. (Dominique Pellé, closes #9416 )
2021-12-27 17:21:41 +00:00
K.Takata
eeec254878
patch 8.2.2922: computing array length is done in various ways
...
Problem: Computing array length is done in various ways.
Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305 )
2021-06-02 13:28:16 +02:00
Bram Moolenaar
4e1d8bd79b
patch 8.2.1335: CTRL-C in the GUI doesn't interrupt
...
Problem: CTRL-C in the GUI doesn't interrupt. (Sergey Vlasov)
Solution: Recognize "C" with CTRL modifier as CTRL-C. (issue #6565 )
2020-08-01 13:10:14 +02:00
Bram Moolenaar
203ec7760d
patch 8.2.1228: scrollbars not flush against the window edges when maximised
...
Problem: Scrollbars not flush against the window edges when maximised.
Solution: Add padding. (Ken Takata, closes #5602 , closes #6466 )
2020-07-17 20:43:43 +02:00
Bram Moolenaar
4b96df5a01
patch 8.2.0156: various typos in source files and tests
...
Problem: Various typos in source files and tests.
Solution: Fix the typos. (Emir Sari, closes #5532 )
2020-01-26 22:00:26 +01:00
Bram Moolenaar
734a867ffe
patch 8.1.2383: using old C style comments
...
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
2019-12-02 22:49:38 +01:00
Bram Moolenaar
c799fe206e
patch 8.1.1414: alloc() returning "char_u *" causes a lot of type casts
...
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
2019-05-28 23:08:19 +02:00
Bram Moolenaar
abab0b0fdd
patch 8.1.1086: too many curly braces
...
Problem: Too many curly braces.
Solution: Remove curly braces where they are not needed. (Hirohito Higashi,
closes #3982 )
2019-03-30 18:47:01 +01:00
Bram Moolenaar
12dfc9eef1
patch 8.1.0840: getchar(0) never returns a character in the terminal
...
Problem: getchar(0) never returns a character in the terminal.
Solution: Call wait_func() at least once.
2019-01-28 22:32:58 +01:00
Bram Moolenaar
135059724f
patch 8.1.0805: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate FEAT_MBYTE, part 1.
2019-01-24 15:04:48 +01:00
Bram Moolenaar
f9e3e09fdc
patch 8.1.0743: giving error messages is not flexible
...
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302 ) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
2019-01-13 23:38:42 +01:00
Bram Moolenaar
6dff58f15c
patch 8.1.0443: unnecessary static function prototypes
...
Problem: Unnecessary static function prototypes.
Solution: Remove unnecessary prototypes.
2018-09-30 21:43:26 +02:00
Bram Moolenaar
d23a823669
patch 8.0.1496: clearing a pointer takes two lines
...
Problem: Clearing a pointer takes two lines.
Solution: Add VIM_CLEAR() and replace vim_clear(). (Hirohito Higashi,
closes #2629 )
2018-02-10 18:45:26 +01:00
Bram Moolenaar
1dd45fb4f3
patch 8.0.1450: GUI: endless loop when stopping cursor blinking
...
Problem: Endless loop when gui_mch_stop_blink() is called while blink_state
is BLINK_OFF. (zdohnal)
Solution: Avoid calling gui_update_cursor() recursively.
2018-01-31 21:10:01 +01:00
Bram Moolenaar
26af85d97b
patch 8.0.0755: terminal window does not have colors in the GUI
...
Problem: Terminal window does not have colors in the GUI.
Solution: Lookup the GUI color.
2017-07-23 16:45:10 +02:00
Bram Moolenaar
edf3f97ae2
patch 7.4.2293
...
Problem: Modelines in source code are inconsistant.
Solution: Use the same line in most files. Add 'noet'. (Naruhiko Nishino)
2016-08-29 22:49:24 +02:00
Bram Moolenaar
1b58cdd160
patch 7.4.2243
...
Problem: Warning for assigning negative value to unsigned. (Danek Duvall)
Solution: Make cterm_normal_fg_gui_color and _bg_ guicolor_T, cast to long_u
only when an unsigned is needed.
2016-08-22 23:04:33 +02:00
Bram Moolenaar
9d5d3c9c44
patch 7.4.1995
...
Problem: GUI: cursor drawn in wrong place if a timer callback causes a
screen update. (David Samvelyan)
Solution: Also redraw the cursor when it's blinking and on.
2016-07-07 16:43:02 +02:00
Bram Moolenaar
703a8044b5
patch 7.4.1890
...
Problem: GUI: When channel data is received the cursor blinking is
interrupted. (Ramel Eshed)
Solution: Don't update the cursor when it is blinking.
2016-06-04 16:24:32 +02:00
Bram Moolenaar
ab3022196e
patch 7.4.1792
...
Problem: Color name decoding is implemented several times.
Solution: Move it to term.c. (Christian Brabandt)
2016-04-26 20:59:29 +02:00
Bram Moolenaar
68c2f638e6
patch 7.4.1208
...
Problem: Using old style function declarations.
Solution: Change to new style function declarations. (script by Hirohito
Higashi)
2016-01-30 17:24:07 +01:00
Bram Moolenaar
84a05acc8c
updated for version 7.3.925
...
Problem: Typos in source files.
Solution: Fix the typos. (Ken Takata)
2013-05-06 04:24:17 +02:00
Bram Moolenaar
8288149866
updated for version 7.3.719
...
Problem: Cannot run new version of cproto, it fails on missing include
files.
Solution: Add lots of #ifndef PROTO
2012-11-20 16:53:39 +01:00
Bram Moolenaar
15d6319b9d
updated for version 7.3.310
...
Problem: Code not following Vim style.
Solution: Fix the style. (Elias Diem)
2011-09-14 16:05:15 +02:00
Bram Moolenaar
0d55ff1594
updated for version 7.3.299
...
Problem: Source code not in Vim style.
Solution: Adjust the style. (Elias Diem)
2011-09-07 19:09:01 +02:00
Bram Moolenaar
092e3c874f
updated for version 7.3.298
...
Problem: Built-in colors are different from rgb.txt.
Solution: Adjust the color values. (Benjamin Haskell)
2011-09-07 18:58:29 +02:00
Bram Moolenaar
d0988c50f3
updated for version 7.3.271
...
Problem: Code not following Vim coding style.
Solution: Fix the style. (Elias Diem)
2011-08-10 12:19:04 +02:00
Bram Moolenaar
d2221131cf
updated for version 7.3.262
...
Problem: Photon code style doesn't match Vim style.
Solution: Clean up some of it. (Elias Diem)
2011-07-27 14:09:09 +02:00
Bram Moolenaar
d2c340a6a6
updated for version 7.3.102
...
Problem: When using ":make", typing the next command and then getting the
"reload" prompt the next command is (partly) eaten by the reload
prompt.
Solution: Accept ':' as a special character at the reload prompt to accept
the default choice and execute the command.
2011-01-17 20:08:11 +01:00
Bram Moolenaar
a0b1997e13
updated for version 7.2-219
2009-07-01 14:13:18 +00:00
Bram Moolenaar
ccc18222dd
updated for version 7.1b
2007-05-10 18:25:20 +00:00
Bram Moolenaar
b21e5843e5
updated for version 7.0e
2006-04-16 18:30:08 +00:00
Bram Moolenaar
e2f98b95c8
updated for version 7.0c03
2006-03-29 21:18:24 +00:00
Bram Moolenaar
afa24990b3
updated for version 7.0c01
2006-03-27 20:58:26 +00:00
Bram Moolenaar
027436338b
updated for version 7.0116
2005-07-25 20:42:36 +00:00
Bram Moolenaar
e2cc9702a6
updated for version 7.0060
2005-03-15 22:43:58 +00:00
Bram Moolenaar
5f2bb9f584
updated for version 7.0037
2005-01-11 21:29:04 +00:00
Bram Moolenaar
9588a0f72b
updated for version 7.0035
2005-01-08 21:45:39 +00:00
Bram Moolenaar
dfccaf0f00
updated for version 7.0027
2004-12-31 20:56:11 +00:00
Bram Moolenaar
d8b0cf1cc5
updated for version 7.0022
2004-12-12 11:33:30 +00:00
Bram Moolenaar
071d4279d6
updated for version 7.0001
2004-06-13 20:20:40 +00:00